Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update math module dep #11819

Merged
merged 1 commit into from
Apr 28, 2022
Merged

chore: update math module dep #11819

merged 1 commit into from
Apr 28, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

  • Published v1.0.0-beta.1 of the math sub-module
  • Remove replace directive in favor of the tagged version

ref: #11788

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez requested a review from aaronc as a code owner April 28, 2022 18:15
@alexanderbez alexanderbez added dependencies Pull requests that update a dependency file A:automerge Automatically merge PR once all prerequisites pass. labels Apr 28, 2022
julienrbrt
julienrbrt approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt
Copy link
Member

Maybe add a changelog entry for the 1.0.0 ?

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Apr 28, 2022 •
edited
Loading

Maybe add a changelog entry for the 1.0.0 ?

To the SDK's changelog? Or the math one? If the latter, I was gonna add a changelog entry once we cut an official (non-beta) release.

@julienrbrt
Copy link
Member

Maybe add a changelog entry for the 1.0.0 ?

To the SDK's changelog? Or the math one? If the latter, I was gonna add a changelog entry once we cut an official (non-beta) release.

I indeed meant the latter, the errors module is as well in beta but does have a changelog.

But your reasoning makes sense.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #11819 (6841e8f) into main (4f04bea) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11819      +/-   ##
==========================================
- Coverage   65.99%   65.94%   -0.06%     
==========================================
  Files         671      669       -2     
  Lines       70788    70424     -364     
==========================================
- Hits        46720    46441     -279     
+ Misses      21373    21313      -60     
+ Partials     2695     2670      -25
Impacted Files Coverage Δ
x/group/keeper/keeper.go 53.36% <0.00%> (-0.43%) ⬇️
math/int.go
math/uint.go

@alexanderbez alexanderbez merged commit 885e3c4 into main Apr 28, 2022
@alexanderbez alexanderbez deleted the bez/update-math-dep branch April 28, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderbez @julienrbrt